[Spring Cloud] Support zone redundant while service instance creating#4253
Merged
jsntcy merged 9 commits intoAzure:mainfrom Dec 27, 2021
Merged
[Spring Cloud] Support zone redundant while service instance creating#4253jsntcy merged 9 commits intoAzure:mainfrom
jsntcy merged 9 commits intoAzure:mainfrom
Conversation
Collaborator
|
Spring Cloud |
Caoxuyang
approved these changes
Dec 23, 2021
added 2 commits
December 23, 2021 16:08
Member
wangzelin007
left a comment
wangzelin007
left a comment
There was a problem hiding this comment.
Hi @Descatles,
If you want to release the new extension version, please write the description of changes into HISTORY.rst and update setup.py.
Contributor
Author
Hello, @wangzelin007 , This code change would release together with our enterprise tier cli, we will upgrade the version right before the enterprise tier announcement on 2022/01/17 and release the CLI. |
wangzelin007
approved these changes
Dec 24, 2021
Member
|
Please add test to cover the new argument. |
Member
|
/azp run |
jsntcy
approved these changes
Dec 27, 2021
|
Azure Pipelines failed to run 1 pipeline(s). |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.